PYTHON-2364 Replace deprecated dns.resolver.query with dns.resolver.resolve #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Looks like I'm unable to see the details of why the evergreen test failed without creating an account. 😞 |
ShaneHarvey
changed the title
ShaneHarvey
requested changes
Apr 22, 2021
ShaneHarvey
reviewed
Apr 22, 2021
Member
ShaneHarvey
left a comment
ShaneHarvey
left a comment
There was a problem hiding this comment.
Thanks for taking this on!
test/test_client.py
Outdated
| from pymongo.srv_resolver import resolver | ||
| patched_resolver = FunctionCallRecorder(resolver.query) | ||
| pymongo.srv_resolver.resolver.query = patched_resolver | ||
| patched_resolver = FunctionCallRecorder(resolver.resolve) |
Member
There was a problem hiding this comment.
This needs to be updated now that we use pymongo.srv_resolver._resolve instead of pymongo.srv_resolver.resolver.resolve.
Contributor
Author
There was a problem hiding this comment.
Let me know if I did this correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following deprecation warning:
/home/jr769/miniconda3/envs/py38/lib/python3.8/site-packages/pymongo/srv_resolver.py:72: DeprecationWarning: please use dns.resolver.resolve() instead results = resolver.query('_mongodb._tcp.' + self.__fqdn, 'SRV', /home/jr769/miniconda3/envs/py38/lib/python3.8/site-packages/pymongo/srv_resolver.py:57: DeprecationWarning: please use dns.resolver.resolve() instead results = resolver.query(self.__fqdn, 'TXT',